Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLORA-63] Membership data model for packages #785

Merged
merged 11 commits into from
Nov 21, 2024
Merged

[FLORA-63] Membership data model for packages #785

merged 11 commits into from
Nov 21, 2024

Conversation

mau5mat
Copy link
Contributor

@mau5mat mau5mat commented Nov 9, 2024 •
edited
Loading

Proposed changes

  • Query Module
    • Add functions for the following logic:
      • Query all packages belonging to a particular packageGroupId
      • Query a packageGroup by packageGroupName
  • Write Tests
    • Create a new module for the tests related to the Querys
    • Look at PackageSpec.hs for inspriation
    • Membership tests (removing, adding)
    • Add two new lines to cleanUp that will delete the new tables that have been added as part of the migrations for this ticket

Contributor checklist

  • My PR is related to FLORA-63
  • I have read and understood the CONTRIBUTING guide
  • I have inserted my change into changelog.d
  • I have updated documentation in ./docs/docs if a public feature has a behaviour change

@mau5mat mau5mat force-pushed the flora-63-membership-data-model-for-packages branch 2 times, most recently from e9cccf3 to 4f9c26b Compare November 13, 2024 00:32
@mau5mat mau5mat force-pushed the flora-63-membership-data-model-for-packages branch 2 times, most recently from 3438916 to 9abbee7 Compare November 17, 2024 20:27
@mau5mat mau5mat force-pushed the flora-63-membership-data-model-for-packages branch from 9abbee7 to a91bd83 Compare November 20, 2024 00:34
@mau5mat mau5mat marked this pull request as ready for review November 20, 2024 21:37
@mau5mat mau5mat force-pushed the flora-63-membership-data-model-for-packages branch from 15e36cd to 33ff2bd Compare November 20, 2024 21:46
@mau5mat mau5mat changed the title Flora 63 membership data model for packages [FLORA-63] Membership data model for packages Nov 20, 2024
@mau5mat mau5mat force-pushed the flora-63-membership-data-model-for-packages branch from 33ff2bd to 5d3ca82 Compare November 20, 2024 22:00
@mau5mat mau5mat requested a review from tchoutri November 20, 2024 22:09
tchoutri
tchoutri requested changes Nov 20, 2024
View reviewed changes
changelog.d/63 Outdated Show resolved Hide resolved
src/core/Flora/Model/PackageGroup/Query.hs Outdated Show resolved Hide resolved
src/core/Flora/Model/PackageGroup/Types.hs Outdated Show resolved Hide resolved
@tchoutri
Copy link
Contributor

@mau5mat Very good PR, only a couple of things to change and I believe we will be good to go!

@mau5mat mau5mat force-pushed the flora-63-membership-data-model-for-packages branch from 170f729 to 97d19ef Compare November 21, 2024 22:58
@mau5mat mau5mat requested a review from tchoutri November 21, 2024 22:59
@mau5mat mau5mat force-pushed the flora-63-membership-data-model-for-packages branch from 9e964d0 to 9be5ab3 Compare November 21, 2024 23:02
@tchoutri tchoutri added the squash+merge me Tell Mergify bot to squash and merge the PR label Nov 21, 2024
@tchoutri
Copy link
Contributor

🎉

@mau5mat mau5mat merged commit 702a402 into flora-pm:development Nov 21, 2024
11 checks passed
@mau5mat mau5mat deleted the flora-63-membership-data-model-for-packages branch November 21, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchoutri tchoutri tchoutri approved these changes

Assignees
No one assigned
Labels
squash+merge me Tell Mergify bot to squash and merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mau5mat @tchoutri